Issue 22 Tailwind and global styles #26
Conversation
Roboto serving as h1 to h6 Urbanist serving as body font
package-lock.json changed to address depreciated packages
| }, | ||
| colors: { | ||
| yellow: "#ffd700", |
There was a problem hiding this comment.
It's better to prefix the wajo color names with wajo- to distinguish them from Tailwind's default class names. Considering addingwajo:{}
There was a problem hiding this comment.
I would require a second opinion on this one from the tech leads @AarifLamat @yunho7687 @Julie-Salazar. I personally think adding identifiers in front of those names would be a bit finicky. For example writing bg-yellow-400 is a lot easier than bg-wajo-yellow-400. By doing yellow: "#ffd700" I've basically overridden Tailwind's default yellow of yellow: "#facc15". So Tailwind's default yellow will never appear again, only ours. If I want to still use Tailwind's default yellow, only then I would distinguish them if it makes sense.
There was a problem hiding this comment.
I would require a second opinion on this one from the tech leads @AarifLamat @yunho7687 @Julie-Salazar. I personally think adding identifiers in front of those names would be a bit finicky. For example writing bg-yellow-400 is a lot easier than bg-wajo-yellow-400. By doing
yellow: "#ffd700"I've basically overridden Tailwind's default yellow ofyellow: "#facc15". So Tailwind's default yellow will never appear again, only ours. If I want to still use Tailwind's default yellow, only then I would distinguish them if it makes sense.
yeah, good point, overwriting it is applicable in this project
I can revert the package-lock.json if needed. All I did was |
|
It can be merged now |
Change Summary
Change Form
N/A. I believe front end stuff doesn't require tests.
Other Information
All styles have been applied with accordance of the current style sheet provided on figma.
Side Note
package-lock.json has been slightly altered to address vulnerabilities and depreciation.
Related issue