generated from codersforcauses/django-nextjs-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 61 add question preview modal component #63
Merged
yunho7687
merged 8 commits into
main
from
issue-61-Add_Question_Preview_Modal_Component
Jan 24, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c49619e
feat(question): add Preview Modal
leonleerl a351e2c
fix(pagination, data-grid): prettier code style modification
leonleerl befe8c8
chore(question): add comment for props
leonleerl 7218402
fix(question): add import
leonleerl 40f6466
fix(preview modal): remain the buttons at the bottom; make the modal …
leonleerl 069bb51
fix(question): render latex content on preview modal
leonleerl 42ea61e
Merge branch 'main' into issue-61-Add_Question_Preview_Modal_Component
leonleerl 9750e17
fix(question): Make DatagridProps generic
leonleerl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import "katex/dist/katex.min.css"; | ||
|
|
||
| import * as VisuallyHidden from "@radix-ui/react-visually-hidden"; | ||
| import { useEffect, useState } from "react"; | ||
| import Latex from "react-latex-next"; | ||
|
|
||
| import { | ||
| Dialog, | ||
| DialogContent, | ||
| DialogDescription, | ||
| DialogTitle, | ||
| DialogTrigger, | ||
| } from "@/components/ui/dialog"; | ||
| import { PreviewModalProps } from "@/types/question"; | ||
|
|
||
| import { Button } from "../button"; | ||
|
|
||
| export default function PreviewModal({ | ||
| children, | ||
| dataContext, | ||
| }: PreviewModalProps) { | ||
| const [question, setQuestion] = useState<string>(dataContext.question); | ||
|
|
||
| useEffect(() => { | ||
| if (dataContext?.question) { | ||
| setQuestion(dataContext.question); | ||
| } | ||
| }, [dataContext]); | ||
| return ( | ||
| <> | ||
| <Dialog> | ||
| <DialogTrigger asChild>{children}</DialogTrigger> | ||
| <DialogContent | ||
| className="flex h-auto w-[95%] max-w-[750px] flex-col items-center rounded-[40px] border-0 bg-accent p-1 shadow-lg" | ||
| style={{ borderRadius: "32px" }} | ||
| > | ||
| <VisuallyHidden.Root> | ||
| <DialogTitle>Preview Data</DialogTitle> | ||
| <DialogDescription></DialogDescription> | ||
| </VisuallyHidden.Root> | ||
|
|
||
| <div className="flex h-full w-full flex-col space-y-4 rounded-[30px] bg-white px-10 py-4 text-xl"> | ||
| {/* Question */} | ||
| <div className="flex-grow space-y-4"> | ||
| <div className="flex space-x-4 text-2xl font-semibold text-gray-600"> | ||
| <span>{dataContext.questionName}</span> | ||
| <span>[{dataContext.mark} marks]</span> | ||
| </div> | ||
| <Latex>{question}</Latex> | ||
| </div> | ||
| {/* Solution */} | ||
| <div> | ||
| <p className="text-2xl font-semibold text-gray-600">Solution</p> | ||
| <div> | ||
| <p> | ||
| Answer:{" "} | ||
| <span className="font-bold">{dataContext.answer}</span> | ||
| </p> | ||
| <p>{dataContext.solution}</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| {/* Close Button */} | ||
| <div className="mt-auto flex justify-center"> | ||
| <DialogTrigger asChild> | ||
| <Button variant={"ghost"} className="w-36 border border-black"> | ||
| Close | ||
| </Button> | ||
| </DialogTrigger> | ||
| </div> | ||
| </div> | ||
| </DialogContent> | ||
| </Dialog> | ||
| </> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| import { PaginationProps } from "@/types/question"; | ||
|
|
||
| export function Pagination({ | ||
| totalPages, | ||
| currentPage, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the naming convention shall be lower case iirc (Question -> question)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yunho. I follow the style-guide.md. It says the folder name in /Components should use PascalCase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, hh, my fault!