Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the logic of attemping a comp #96

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

yunho7687
Copy link
Member

All the core functionality of the competition system has done:

  1. create questions in question-bank
  2. create quizzes and mark it is a upcoming competition
  3. let only student attempt the competition
  4. allow extension time to a student

to do list:

  1. automatically calculate the marks of students' competition attemptation.
  2. automatically calculate the total marks of a quiz
  3. above need to be done after the merge of this PR and added answer model #87
  4. invoice ( maybe need to be done by the frontend

@yunho7687 yunho7687 requested a review from AarifLamat January 28, 2025 08:31
Copy link
Contributor

@Julie-Salazar Julie-Salazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, (mainly just getting rid of print(0 debug code by yunho)

@yunho7687 yunho7687 self-assigned this Jan 28, 2025
@yunho7687 yunho7687 added backend Task must have a back end issue bug Something isn't working labels Jan 28, 2025
yunho7687 and others added 12 commits January 29, 2025 02:43
…rver

- feat(auth): include 'role' field in JWT token for role-based access control
- refactor(client-server): replace client-side mock API with proper server communication
- chore: ensure seamless integration between client and server endpoints
…e retrieval

- refactor(auth): clean up JWT payload by removing unnecessary fields
- feat(auth): add function to extract and utilize the 'role' field from JWT token
- fix(api): add trailing slash to endpoint URLs (e.g., questions/question-bank) to resolve CORS errors
- feat(auth): configure Bearer token in axios instance for authenticated API requests
…ution_text, and update answers handling in create method
Copy link
Contributor

@Julie-Salazar Julie-Salazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yunho7687 yunho7687 merged commit 1cf66d0 into main Jan 29, 2025
5 checks passed
@yunho7687 yunho7687 deleted the optimize-the-logic-of-attemping-a-comp branch January 29, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task must have a back end issue bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants