fix: dynamically reconfigure codemirror instead of recreate on rerender #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@danieldelcore is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
danieldelcore
force-pushed
the
decorator-updates
branch
from
f0b15e5 to
33f4ada
Compare
danieldelcore
changed the title
danieldelcore
changed the title
|
cc: @CompuIves / @danilowoz would really appreciate your 👁️ 👁️ on this one if you have some time 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Legend! Thanks so much! |
|
It seems that something went wrong with the production build: https://sandpack.codesandbox.io/docs/quickstart I will investigate it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1124
This PR separates codemirror instantiation logic from subsequent prop updates.
Previously every time a decorator or other dependency is updated, it would trigger a complete recreation of the sandpack instance, resulting in strange behaviour such as the cursor would be repositioned or elements would flash.
To fix this, I've moved all extension configuration into a seperate hook, when rerun will recreate the entire config and dispatch a codemirror
reconfiguremessage which safely updates the instance without any side effects.I have added a storybook example which illustrates the behaviour.