Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development 1.1 leave excuse #392

Merged
merged 7 commits into from
Apr 14, 2024

Conversation

maayarosama
Copy link
Collaborator

Frontend feature done

Related Issues

#382
#389

@maayarosama maayarosama marked this pull request as draft March 27, 2024 13:01
@maayarosama maayarosama changed the base branch from development to development_1.1 March 27, 2024 13:02
@maayarosama maayarosama marked this pull request as ready for review April 3, 2024 01:12
@Mahmoud-Emad
Copy link
Collaborator

Mahmoud-Emad commented Apr 4, 2024

I don't know what is the Leave Request and its value is 365 days.

image

The Leave excuse is added in the backend as you see and its value for the logged-in user is only 6

image

and when applied I got this error, makes sense we sent an unavailable choice.

image

@Mahmoud-Emad
Copy link
Collaborator

Mahmoud-Emad commented Apr 4, 2024

I think we need to update the alert with the new value since the selected start and dates are the same day and the leave will be from 08:00 PM till 10:00 PM which means the leave will be only 0.25 day not 1 day

image

@Mahmoud-Emad
Copy link
Collaborator

Also i got wrong date format

image

@maayarosama maayarosama merged commit 08ec3af into development_1.1 Apr 14, 2024
2 checks passed
@maayarosama maayarosama deleted the development_1.1_leave_excuse branch April 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants