Add zarr as a fix for zar. #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
added a commit
to yarikoptic/icechunk
that referenced
this pull request
Oct 15, 2024
but not yet known for not long: codespell-project/codespell#3568
paraseba
added a commit
to earth-mover/icechunk
that referenced
this pull request
Oct 15, 2024
…t fix few typos (#267) * Add github action to codespell main on push and PRs * Add pre-commit definition for codespell * Fix manually not yet known to codespell Zar typo but not yet known for not long: codespell-project/codespell#3568 * Add rudimentary codespell config * [DATALAD RUNCMD] run codespell throughout fixing typos automagically (but ignoring overall fail due to ambigous ones) === Do not change lines below === { "chain": [], "cmd": "codespell -w || :", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * [DATALAD RUNCMD] Do interactive fixing of some ambigous typos === Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * Mark remaining ignores for codespell * Fix expected by rust spacing to inline comment Co-authored-by: Sebastián Galkin <[email protected]> --------- Co-authored-by: Sebastián Galkin <[email protected]>
codespell_lib/data/dictionary.txt
Outdated
| zar->czar | ||
| zars->czars | ||
| zar->czar, zarr | ||
| zars->czars, zarrs |
There was a problem hiding this comment.
Zarr is OK, but not sure about the plural Zarrs.
Don't forget the trailing comma.
There was a problem hiding this comment.
sorry, what trailing comma?
There was a problem hiding this comment.
I guess not to leave it behind... ok let's do:
Suggested change
| zars->czars, zarrs | |
| zars->czars |
DimitriPapadopoulos
force-pushed
the
zarr
branch
from
5a3314f
to
dc65c5e
Compare
DimitriPapadopoulos
approved these changes
Oct 20, 2024
DimitriPapadopoulos
force-pushed
the
zarr
branch
from
dc65c5e
to
15aac2e
Compare
Zarr is a new community driven data format, discover more https://en.wikipedia.org/wiki/Zarr_(data_format) and I ran into this while fixing a Zarr related project Co-authored-by: Dimitri Papadopoulos <[email protected]>
DimitriPapadopoulos
force-pushed
the
zarr
branch
from
15aac2e
to
5d73e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zarr is a new community driven data format, discover more https://en.wikipedia.org/wiki/Zarr_(data_format)
and I ran into this while fixing a Zarr related project