Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forach->foreach, orach, spelling correction #3576

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

cfi-gb
Copy link
Contributor

@cfi-gb cfi-gb commented Nov 7, 2024

See e.g. https://grep.app/search?q=forach&words=true

Note: Wasn't sure about the placement so put it into the dictionary_code.txt first but could be also moved into the more generic one.

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Nov 7, 2024
@DimitriPapadopoulos
Copy link
Collaborator

Actually, dictionary_code.txt is for words that are not typos in the context of code. For example, this would be a good candidate:

foreach-> for each

Therefore I would indeed move to the generic dictionary, perhaps as:

forach-> foreach, orach,

@cfi-gb cfi-gb changed the title Add forach->foreach spelling correction Add forach->foreach, orach, spelling correction Nov 7, 2024
@cfi-gb
Copy link
Contributor Author

cfi-gb commented Nov 7, 2024

Thanks a lot for the feedback / hint, adjusted the PR accordingly 👍

@DimitriPapadopoulos DimitriPapadopoulos merged commit ce7c44e into codespell-project:main Nov 8, 2024
15 checks passed
@cfi-gb cfi-gb deleted the add_forach branch November 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants