Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language CLIPS, add structures Facts and Rules to CLIPS 6.4.1 #744

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

mrryanjohnston
Copy link
Contributor

What GitHub issue does this PR apply to?

Resolves #743

What changed and why?

I added the CLIPS programming language, as well as 2 structures and 4 concepts.

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

Is there an automated way to test my changes?

@geekygirlsarah
Copy link
Member

I started writing a comment on another computer and forgot to send!

Is there an automated way to test my changes?

There's a few ways of varying amounts of "automated":

  1. Run the validate commands (python manage.py validatemetainfofile and python manage.py validatelanginfofiles, same things run on PRs)
  2. Run the Docker container with the site and test it there to see if results are what you expect
  3. Install and run it on your computer and test it there to see if results are what you expect

I also noticed the contributions add new concepts (which you figured out on your own). I'll probably make some suggestions to help them match some styles we have on other concept files.

@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-744 July 31, 2024 01:24 Inactive
web/thesauruses/_meta/facts.json Outdated Show resolved Hide resolved
web/thesauruses/_meta/rules.json Outdated Show resolved Hide resolved
web/thesauruses/_meta/facts.json Outdated Show resolved Hide resolved
web/thesauruses/_meta/rules.json Outdated Show resolved Hide resolved
@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-744 July 31, 2024 18:19 Inactive
@geekygirlsarah
Copy link
Member

So the tl;dr of my not merging yet is that it crashes when trying to look up this change. It's not the fault of this, and I made issue #746 for this. So it'll have to wait to get merged until that's resolved!

@mrryanjohnston
Copy link
Contributor Author

So the tl;dr of my not merging yet is that it crashes when trying to look up this change. It's not the fault of this, and I made issue #746 for this. So it'll have to wait to get merged until that's resolved!

No rush :) let me know if I can help

@geekygirlsarah geekygirlsarah mentioned this pull request Oct 5, 2024
5 tasks
@geekygirlsarah
Copy link
Member

I think #751 fixed the bug on #746 to make this work! I can merge it in now. Thanks for adding to this!

I think since this was created before October it doesn't count towards Hacktoberfest, but this project is opted in, so if you want to keep contributing, future PRs in October would count towards the 4 PRs!

@geekygirlsarah geekygirlsarah merged commit b28e04b into codethesaurus:main Oct 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLIPS
2 participants