Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "unknowns" in CLIPS #753

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix "unknowns" in CLIPS #753

merged 1 commit into from
Oct 5, 2024

Conversation

geekygirlsarah
Copy link
Member

What GitHub issue does this PR apply to?

Resolves #752

What changed and why?

  • Merged the two facts parts into one category
  • Merged the two rules parts into one category
  • Renamed the concept IDs in CLIPS so they show up correctly

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@geekygirlsarah geekygirlsarah merged commit c6ec0f7 into codethesaurus:main Oct 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Clips rules don't show up correctly
1 participant
@geekygirlsarah