-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add volunteer AldrinSeanPereira #79
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
data/users/AldrinSeanPereira.json
Outdated
{ | ||
"name": "Aldrin Sean Pereira", | ||
"bio": "Software Engineer", | ||
"image": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey you missed the image URL.
Here is your GitHub's avatar URL https://avatars.githubusercontent.com/u/54813708?v=4
you can use it.
data/users/AldrinSeanPereira.json
Outdated
"image": "", | ||
"categories": [ | ||
{ | ||
"slug": "programming | software-development", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one slug should be added!
data/users/AldrinSeanPereira.json
Outdated
"categories": [ | ||
{ | ||
"slug": "programming | software-development", | ||
"topics": [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add topics which you are good at like javascript
or python
Thanks for volunterring @AldrinSeanPereira :). PTAL at @RakeshSangem's comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected my PR. Thanks to the reviewers for taking the time to help!!
@RakeshSangem @codewithvoid
data/users/AldrinSeanPereira.json
Outdated
{ | ||
"name": "Aldrin Sean Pereira", | ||
"bio": "Software Engineer", | ||
"image": "C:\Users\admin\Downloads\20220704_154207.jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use github image url here like
https://avatars.githubusercontent.com/u/54813708?v=4
@AldrinSeanPereira added small comments. PTAL. |
got it. thank you @codewithvoid 🥰❤️ |
specified only programming languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes made according to @codewithvoid's suggestions :)
"image": "https://avatars.githubusercontent.com/u/54813708?v=4", | ||
"categories": [ | ||
{ | ||
"slug": "software-development", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to programming
"categories": [ | ||
{ | ||
"slug": "software-development", | ||
"topics": [C, C#, Python] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be in quotes to be in valid json
"topics": ["C", "C#", "Python"]
I'd like to make my first PR with this wonderful project!