Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add volunteer AldrinSeanPereira #79

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AldrinSeanPereira
Copy link

I'd like to make my first PR with this wonderful project!

@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ask-devs ✅ Ready (Inspect) Visit Preview Dec 25, 2022 at 10:30AM (UTC)

{
"name": "Aldrin Sean Pereira",
"bio": "Software Engineer",
"image": "",
Copy link
Contributor

@RakeshSangem RakeshSangem Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey you missed the image URL.

Here is your GitHub's avatar URL https://avatars.githubusercontent.com/u/54813708?v=4 you can use it.

"image": "",
"categories": [
{
"slug": "programming | software-development",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one slug should be added!

"categories": [
{
"slug": "programming | software-development",
"topics": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add topics which you are good at like javascript or python

@codewithvoid
Copy link
Owner

Thanks for volunterring @AldrinSeanPereira :). PTAL at @RakeshSangem's comments.

@codewithvoid codewithvoid changed the title Create AldrinSeanPereira.json chore: add volunteer AldrinSeanPereira Dec 1, 2022
Copy link
Author

@AldrinSeanPereira AldrinSeanPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected my PR. Thanks to the reviewers for taking the time to help!!
@RakeshSangem @codewithvoid

{
"name": "Aldrin Sean Pereira",
"bio": "Software Engineer",
"image": "C:\Users\admin\Downloads\20220704_154207.jpg",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use github image url here like

https://avatars.githubusercontent.com/u/54813708?v=4

@codewithvoid
Copy link
Owner

@AldrinSeanPereira added small comments. PTAL.

@AldrinSeanPereira
Copy link
Author

got it. thank you @codewithvoid 🥰❤️

specified only programming languages
Copy link
Author

@AldrinSeanPereira AldrinSeanPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes made according to @codewithvoid's suggestions :)

"image": "https://avatars.githubusercontent.com/u/54813708?v=4",
"categories": [
{
"slug": "software-development",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to programming

"categories": [
{
"slug": "software-development",
"topics": [C, C#, Python]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be in quotes to be in valid json

   "topics": ["C", "C#", "Python"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants