Adds tests for other stream exceptions. Cleanup.

codex/chunker.nim

@@ -93,10 +93,10 @@ proc new*(
     except CancelledError as error:
       raise error
     except LPStreamError as error:
-      warn "LPStream error", err = error.msg
+      error "LPStream error", err = error.msg
       raise error
     except CatchableError as exc:
-      trace "CatchableError exception", exc = exc.msg
+      error "CatchableError exception", exc = exc.msg
       raise newException(Defect, exc.msg)
 
     return res
@@ -130,7 +130,7 @@ proc new*(
     except CancelledError as error:
       raise error
     except CatchableError as exc:
-      trace "CatchableError exception", exc = exc.msg
+      error "CatchableError exception", exc = exc.msg
       raise newException(Defect, exc.msg)
 
     return total

tests/codex/testchunking.nim

@@ -1,4 +1,3 @@
-
 import pkg/stew/byteutils
 import pkg/codex/chunker
 import pkg/codex/logutils
@@ -89,13 +88,30 @@ asyncchecksuite "Chunking":
       string.fromBytes(data) == readFile(path)
       fileChunker.offset == data.len
 
-  test "Should forward LPStreamError":
+  proc raiseStreamException(exc: ref CatchableError) {.async.} =
     let stream = CrashingStreamWrapper.new()
     let chunker = LPStreamChunker.new(
       stream = stream,
       chunkSize = 2'nb)
 
-    stream.toRaise = newException(LPStreamError, "test error")
+    stream.toRaise = exc
+    discard (await chunker.getBytes())
+
+  test "stream should forward LPStreamError":
+    expect LPStreamError:
+      await raiseStreamException(newException(LPStreamError, "test error"))
+
+  test "stream should catch LPStreamEOFError":
+    await raiseStreamException(newException(LPStreamEOFError, "test error"))
+
+  test "stream should forward CancelledError":
+    expect CancelledError:
+      await raiseStreamException(newException(CancelledError, "test error"))
 
+  test "stream should forward LPStreamError":
     expect LPStreamError:
-      discard (await chunker.getBytes())
+      await raiseStreamException(newException(LPStreamError, "test error"))
+
+  test "stream should convert other exceptions to defect":
+    expect Defect:
+      await raiseStreamException(newException(CatchableError, "test error"))