Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grouper): handle out-of-type diff calculations #275

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nikmel2803
Copy link
Member

@nikmel2803 nikmel2803 commented Aug 27, 2021

The problem: the PHP catcher sends some data via the incompatible format under invalid names and types. This issue was reported under codex-team/hawk.php#39

Such fields leads to the issues with diff calculation since fields could have different structure and types.

function arrayDiff(source, target) {
const diffArray = [];
for (let i = 0; i < target.length; i++) {
diffArray[i] = deepDiff(source[i], target[i]);
}
return diffArray;
}

Resolves #312

@neSpecc neSpecc self-assigned this Aug 2, 2022
@neSpecc neSpecc changed the title add failed test case to deepDiff fix(grouper): handle out-of-type diff calculations Aug 2, 2022
@neSpecc neSpecc marked this pull request as ready for review August 2, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouper: cannot read property '0' of undefined
2 participants