Initialised the PULL_REQUEST_TEMPLATE.md

PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,37 @@
+## Description
+
+<!--- Describe your changes in detail -->
+
+## Related Issue
+
+<!--- If suggesting a new feature or change, please discuss it in an issue first -->
+<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
+<!--- Please link to the issue here: -->
+
+
+## How Has This Been Tested?
+
+<!--- Please describe in detail how you tested your changes. -->
+<!--- Include details of your testing environment, and the tests you ran to -->
+<!--- see how your change affects other areas of the code, etc. -->
+
+## Screenshots (if appropriate):
+
+## Types of changes:
+
+<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to change)
+
+## Checklist:
+
+<!--- Put a `X` in all the boxes that apply. -->
+
+- [X] My code follows the code style of this project.
+- [ ] My change requires a change to the documentation.
+- [ ] I have updated the documentation accordingly.
+- [X] I have read the **CONTRIBUTING** document.
+- [ ] I have added tests to cover my changes.
+- [X] All new and existing tests passed.

package.json

@@ -52,8 +52,8 @@
   },
   "apidoc": {
     "title": "judge-blocks API",
-    "url": "http://judge.cb.lk/api",
-    "sampleUrl": "http://judge.cb.lk/api"
+    "url": "https://judge2.codingblocks.com/api",
+    "sampleUrl": "https://judge2.codingblocks.com/api"
   },
   "nyc": {
     "extension": [

src/routes/api/run.ts

@@ -50,6 +50,8 @@ const handleTimeoutForSubmission = function (submissionId: number) {
     case 'callback':
       axios.post(job.callback, errorResponse)
   }
+
+  delete runPool[submissionId]
 }
 
 const handleSuccessForSubmission = function (result: RunResponse) {
@@ -79,6 +81,8 @@ const handleSuccessForSubmission = function (result: RunResponse) {
       })()
       break;
   }
+
+  delete runPool[result.id]
 }
 
 /**
@@ -109,7 +113,7 @@ const getRunPoolElement = function (body: RunRequestBody, res: Response): RunPoo
  *
  * @apiParam {String(Base64)} source source code to run (encoded in base64)
  * @apiParam {Enum} lang Language of code to execute
- * @apiParam {String(Base64)} input [Optional] stdin input for the program (encoded in base64)
+ * @apiParam {String(Base64)} stdin [Optional] stdin input for the program (encoded in base64)
  * @apiParam {Enum} mode [Optional] mode for request. Default = `sync`, see: https://github.com/coding-blocks/judge-api/issues/16
  * @apiParam {String)} callback [Optional] callback url for request. Required for `mode = callback`
  * @apiParam {String)} enc [Optional] Encoding type for stdin and source. Can be `url`|`base64`. Default = 'base64' 
@@ -172,7 +176,6 @@ route.post('/', (req, res, next) => {
     setTimeout(() => {
       if (runPool[submission.id]) {
         handleTimeoutForSubmission(submission.id)
-        delete runPool[submission.id]
       }
     }, config.RUN.TIMEOUT)
 
@@ -198,7 +201,6 @@ route.post('/', (req, res, next) => {
 successListener.on('success', (result: RunResponse) => {
   if (runPool[result.id]) {
     handleSuccessForSubmission(result)
-    delete runPool[result.id]
   }
   Submissions.update(<any>{
     end_time: new Date()

src/utils/s3.ts

@@ -5,8 +5,8 @@ import config = require('../../config')
 
 const client = new Minio.Client({
   endPoint: config.S3.endpoint,
-  port: config.S3.port,
-  useSSL: config.S3.ssl,
+  port: +config.S3.port,
+  useSSL: !!config.S3.ssl,
   accessKey: config.S3.accessKey,
   secretKey: config.S3.secretKey,
 })

src/validators/ApiKeyValidators.ts

@@ -4,7 +4,8 @@ import {ApiKeyAttrs, ApiKeys} from '../db/models'
 
 export function checkValidApiKey (req: Request): Promise<boolean> {
   return new Promise((resolve, reject) => {
-    let apiKey = req.header('Authorization').split('Bearer ')[1]
+    let apiKey = req.header('Authorization')
+    apiKey = apiKey && apiKey.split('Bearer ')[1]
     if (!apiKey) {
       reject(new Error('No API Key in request'))
     }
@@ -42,4 +43,4 @@ export function checkValidApiKey (req: Request): Promise<boolean> {
 
 
 
-}
+}