Port the entire project to F# and ASP.NET Core #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagane
approved these changes
Oct 16, 2016
| type HomeController() = | ||
| inherit Controller() | ||
|
|
||
| let logUrlPrefix = "http://0xd34df00d.me/logs/chat/[email protected]" |
There was a problem hiding this comment.
Should be configurable. We shouldn't rely on Mr Dead Food's server to be online and accessible by that hostname.
There was a problem hiding this comment.
Agreed. Will extract to separate task (#39).
There was a problem hiding this comment.
See also #27 for a long-term targets.
|
Looks ok for me. 🐐 |
gsomix
approved these changes
Oct 16, 2016
|
Thank you, guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
So, I've decided to give up on vibe.d (I really tried and... wasn't excited about it). And the site is rewritten in F# now. I'm going to improve it in the future, but it's in a pretty decent state already. It fully supersedes current Yesod implementation, and all of the functionality (i.e. both the working routes) remained fully compatible with the old site.
Impact
Closes #13 (yep, it was so extremely easy to implement that I just had to). Closes #32. Closes #34. Also the updated resources link (#30) and copyright year (happy fawkin' 2016 finally, just about time) will finally be able to arrive to production.
Infrastructure
I've already evaluated .NET Core runtime on the production server, and it seems to work. I'll deploy the site soon after the review and merge.
Review
I'd like to either @rexim or @gsomix to review my changes. Also, @hagane may be interested. Will merge after 1/3 or 2/3 approval ratio.