feat: unify typography #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for home-goods-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisey
force-pushed
the
shiree/typography
branch
from
13923ef to
3379b96
Compare
Closed
alisey
commented
Dec 19, 2024
| @@ -104,6 +103,6 @@ | |||
| flex-direction: column-reverse; | |||
| align-items: start; | |||
| justify-content: center; | |||
| font-size: 13px; | |||
| font: var(--paragraph3); | |||
There was a problem hiding this comment.
This is redundant, it's the same as in desktop mode.
alisey
commented
Dec 19, 2024
| @@ -190,7 +190,7 @@ | |||
| } | |||
|
|
|||
| .textPage h2 { | |||
| font-size: 20px; | |||
| font-size: 18px; | |||
There was a problem hiding this comment.
Is this an intentional override?
alisey
commented
Dec 19, 2024
| @@ -307,7 +307,7 @@ | |||
|
|
|||
| @container (max-width: 300px) { | |||
| .linkCardTitle { | |||
| font-size: 30px; | |||
| font: var(--heading4); | |||
There was a problem hiding this comment.
Redundant, same as on desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #263, but without changes that are not related to typography.