Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests & support django 1.10.1+ #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.idea/*
build/*
**.pyc
61 changes: 30 additions & 31 deletions django_qunit/templates/qunit/index.html
Original file line number Diff line number Diff line change
@@ -1,35 +1,34 @@
<!DOCTYPE html>
<html>
<head>
<title>QUnit Test Suite</title>
<link rel="stylesheet" href="{% url qunit_css %}" type="text/css" media="screen">
<script type="text/javascript" src="{% url qunit_js %}"></script>
{% for url in suite.extra_urls %}
<script type="text/javascript" src="{{ url }}"></script>
{% endfor %}
{% for url in suite.extra_media_urls %}
<script type="text/javascript" src="{{ MEDIA_URL }}{{ url }}"></script>
{% endfor %}
{% for file in files %}
<script type="text/javascript" src="{% url qunit_test file %}"></script>
{% endfor %}
</head>
<body>
<h1 id="qunit-header">QUnit Test Suite ({{ suite.name|capfirst }})</h1>
<h2 id="qunit-banner"></h2>
<div id="qunit-testrunner-toolbar"></div>
{% if in_directory or subsuites %}
<div id="navigation">
{% if in_subdirectory %}
<a href="{% url qunit_test_overview previous_directory %}">..</a>
<head>
<title>QUnit Test Suite</title>
<link rel="stylesheet" href="{% url 'qunit_css' %}" type="text/css" media="screen">
<script type="text/javascript" src="{% url 'qunit_js' %}"></script>
{% for url in suite.extra_urls %}
<script type="text/javascript" src="{{ url }}"></script>
{% endfor %}
{% for url in suite.extra_media_urls %}
<script type="text/javascript" src="{{ MEDIA_URL }}{{ url }}"></script>
{% endfor %}
{% for file in files %}
<script type="text/javascript" src="{% url 'qunit_test' file %}"></script>
{% endfor %}
</head>
<body>
<h1 id="qunit-header">QUnit Test Suite ({{ suite.name|capfirst }})</h1>
<h2 id="qunit-banner"></h2>
<div id="qunit-testrunner-toolbar"></div>
{% if in_directory or subsuites %}
<div id="navigation">
{% if in_subdirectory %}
<a href="{% url qunit_test_overview previous_directory %}">..</a>
{% endif %}
{% for suite in subsuites %}
<a href="{{ suite }}/">{{ suite }}</a>
{% endfor %}
</div>
{% endif %}

{% for suite in subsuites %}
<a href="{{ suite }}/">{{ suite }}</a>
{% endfor %}
</div>
{% endif %}
<h2 id="qunit-userAgent"></h2>
<ol id="qunit-tests"></ol>
</body>
<h2 id="qunit-userAgent"></h2>
<ol id="qunit-tests"></ol>
</body>
</html>
25 changes: 11 additions & 14 deletions django_qunit/urls.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
from django.conf.urls.defaults import *
from django.conf.urls import *
from django.conf import settings

from django.views.static import serve
from django_qunit import views

import os

media_root = os.path.join(os.path.dirname(__file__), 'media')

urlpatterns = patterns('',
url(r'^tests/(?P<path>.*)$', 'django.views.static.serve', {
'document_root': settings.QUNIT_TEST_DIRECTORY,
}, name='qunit_test'),
url(r'^qunit/qunit.js', 'django.views.static.serve', {
'document_root': media_root, 'path': 'qunit/qunit.js',
}, name='qunit_js'),
url(r'^qunit/qunit.css', 'django.views.static.serve', {
'document_root': media_root, 'path': 'qunit/qunit.css',
}, name='qunit_css'),
url('^(?P<path>.*)$', 'django_qunit.views.run_tests',
name='qunit_test_overview'),
)
urlpatterns = [
url(r'^tests/(?P<path>.*)$', serve, { 'document_root': settings.QUNIT_TEST_DIRECTORY, }, name='qunit_test'),
url(r'^qunit/qunit.js', serve, { 'document_root': media_root, 'path': 'qunit/qunit.js', }, name='qunit_js'),
url(r'^qunit/qunit.css', serve, { 'document_root': media_root, 'path': 'qunit/qunit.css',}, name='qunit_css'),
url('^(?P<path>.*)$', views.run_tests, name='qunit_test_overview'),
]
6 changes: 3 additions & 3 deletions django_qunit/views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.shortcuts import render_to_response
from django.conf import settings
from django.utils import simplejson
import json

import os

Expand All @@ -24,8 +24,8 @@ def get_suite_context(request, path):
# load suite.json if present
if 'suite.json' in files:
file = open(os.path.join(full_path, 'suite.json'), 'r')
json = file.read()
suite.update(simplejson.loads(json))
suite_json = file.read()
suite.update(json.loads(suite_json))

previous_directory = parent_directory(path)

Expand Down
9 changes: 9 additions & 0 deletions example/manage.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/usr/bin/env python
import os
import sys

if __name__ == "__main__":

from django.core.management import execute_from_command_line

execute_from_command_line(sys.argv)
2 changes: 1 addition & 1 deletion example/runserver.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh

PYTHONPATH=`pwd`:`pwd`/..:$PYTHONPATH
django-admin.py runserver --settings=settings 8080
python manage.py runserver --settings=settings 8080
4 changes: 3 additions & 1 deletion example/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
DEBUG = True
TEMPLATE_DEBUG = DEBUG

ROOT_URLCONF = 'example.urls'
ROOT_URLCONF = 'urls'

INSTALLED_APPS = (
'django_qunit',
)

SECRET_KEY = 'foo'
6 changes: 3 additions & 3 deletions example/urls.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.conf.urls.defaults import *
from django.conf.urls import *

urlpatterns = patterns('',
urlpatterns = [
url('^qunit/', include('django_qunit.urls'))
)
]