fix: minor bugs/comments

coffee-tools · Dec 30, 2023 · e1c4440 · e1c4440
1 parent a14cc48
commit e1c4440
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/coffee_cmd/src/main.rs b/coffee_cmd/src/main.rs
@@ -65,9 +65,7 @@ async fn main() -> Result<(), CoffeeError> {
             };
             match coffee.upgrade(&repo, verbose).await {
                 Ok(res) => {
-                    if let Some(spinner) = spinner {
-                        spinner.finish();
-                    }
+                    spinner.and_then(|splinner| Some(splinner.finish()));
                     match res.status {
                         UpgradeStatus::UpToDate => {
                             term::info!("Remote repository `{}` is already up to date!", res.repo)
@@ -81,9 +79,7 @@ async fn main() -> Result<(), CoffeeError> {
                     }
                 }
                 Err(err) => {
-                    if let Some(spinner) = spinner {
-                        spinner.failed();
-                    }
+                    spinner.and_then(|spinner| Some(spinner.failed()));
                     return Err(err);
                 }
             }

diff --git a/coffee_core/src/coffee.rs b/coffee_core/src/coffee.rs
@@ -345,7 +345,6 @@ impl PluginManager for CoffeeManager {
         let status = repository.upgrade(&self.config.plugins).await?;
         for plugins in status.plugins_effected.iter() {
             self.remove(plugins).await?;
-            // FIXME: pass the verbose flag to the upgrade command
             self.install(plugins, verbose, false).await?;
         }
         self.flush().await?;

diff --git a/coffee_lib/src/plugin.rs b/coffee_lib/src/plugin.rs
@@ -149,7 +149,7 @@ impl Plugin {
     }
 
     /// upgrade the plugin to a new version.
-    pub async fn upgrade(&mut self, verbose: bool) -> Result<(), CoffeeError> {
+    pub async fn upgrade(&mut self, _: bool) -> Result<(), CoffeeError> {
         todo!("not implemented yet")
     }