-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement coffee nurse
Handler for Locally Missing Repository
#197
Implement coffee nurse
Handler for Locally Missing Repository
#197
Conversation
✅ Deploy Preview for coffee-docs canceled.
|
Signed-off-by: Tarek <[email protected]>
…entStrategy Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
bf617d8
to
9dc94a0
Compare
coffee nurse
Handler for Locally Missing Repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job. I really like this.
I wondered what happens if I delete the repositories
directory and not just a sub-directory.
Maybe the directory is a default one and it is always created, right?
Yes, we call check_dir_or_make_if_missing(format!("{def_path}/repositories")).await?; with each command |
Signed-off-by: Tarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Small comment but this can be a followup PR
Ok(nurse) => { | ||
// special case: if the nurse is sane | ||
// we print a message and return | ||
if nurse.status[0] == NurseStatus::Sane { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future we should like to have a struct
struct NurseStatus {
defects: Vec<...>,
}
impl NurseStatus {
fn is_sane(&self) -> bool {
....
}
}
Amazing! |
No description provided.