-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'g C-a' like incremental increment functionality, support block selections, and more #11
Open
juliapath
wants to merge
127
commits into
cofi:master
Choose a base branch
from
juliapath:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an extra |
For example suppose we have the following where | is point and $ is mark and execute evil-numbers/inc-at-point. ``` |9 9$ ``` Expected: ``` 10 10 ``` Actual: ``` 10 9 ``` This is because we would save the beginning and end of the region before we do any changes, so the second 9 is pushed out of the saved region bounds by the first 9 turning into a 10.
@noctuid Thank you. |
E.g. in the following position (where ^ shows where point is) we want to increase 2, not 1 when calling inc-at-pt. 1 2 ^
juliapath
changed the title
Add 'g C-a' like incremental increment functionality.
Add 'g C-a' like incremental increment functionality, support block selections, and some fixes.
Nov 10, 2018
Previously negative numbers were not padded at all. Specifically calling inc-at-pt on -1 yields +1.
juliapath
changed the title
Add 'g C-a' like incremental increment functionality, support block selections, and some fixes.
Add 'g C-a' like incremental increment functionality, support block selections, and more
Nov 11, 2018
This can help people who defer a lot of package-loading.
Explicitly require evil.
The magic autoload comment only works automatically for defun and the like. For macros such as evil-define-operator it will copy over the whole definition resulting in errors due to other parts of the file not being loaded.
Autoload operators as interactive commands
Imagine we're editing hyphen-separated numbers like the following: cursor: v text: 2020-01-02 When we invoke 'inc-at-pt', we want the last number to change: cursor: v text: 2020-01-01 (Note that the number is decremented instead of being incremented due to the leading '-'. This also matches Vim behavior) However, evil-numbers currently change the first number instead: cursor: v text: 2021-01-02 This patch fixes evil-numbers to match the expected behavior.
fix: handle hyphen-separated numbers correctly
Resolve Warning: looking-back called with 1 argument, but requires 2-3.
Also add explanation for why initialize in packages is needed.
This would have prevented bug #18, as well as related issues from happening in the future.
There have been issues in the past where the newline boundary was ignored. Add another test to ensure it's not. Signed-off-by: Campbell Barton <[email protected]>
Add fill-column local variable.
This contains a few fixes and improvements which are now every well tested and justify being in a release.
Avoids the need for manual formatting.
Avoids the need for `progn` adding/removing when using multiple statements in the first condition.
Both give warnings with melpazoid.
Quiet deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if incremental increment is a good description, but it was the best I could come up with.