fix(react-components): deduplicate result models from `useModelsForIn…

…stanceQuery` (#4657) * fix(react-components): deduplicate result models from `useModelsForInstanceQuery`
cognitedata · Jul 4, 2024 · 9fd6481 · 9fd6481
1 parent 09f9f1f
commit 9fd6481
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/react-components/src/query/useModelsForInstanceQuery.ts b/react-components/src/query/useModelsForInstanceQuery.ts
@@ -16,6 +16,8 @@ import {
   isAssetInstance,
   isDmsInstance
 } from '../utilities/types';
+import { uniqBy } from 'lodash';
+import { createAddOptionsKey } from '../utilities/createAddOptionsKey';
 
 export const useModelsForInstanceQuery = (
   instance: InstanceReference | undefined
@@ -53,9 +55,11 @@ async function getModelsForAssetInstance(
     cogniteClient
   );
 
-  return (
+  const results = (
     await Promise.all([cadModelsPromise, pointCloudModelsPromise, image360CollectionsPromise])
   ).flat();
+
+  return uniqBy(results, createAddOptionsKey);
 }
 
 async function getModelsForFdmInstance(

diff --git a/react-components/src/utilities/createAddOptionsKey.ts b/react-components/src/utilities/createAddOptionsKey.ts
@@ -0,0 +1,20 @@
+/*!
+ * Copyright 2024 Cognite AS
+ */
+import {
+  is360ImageDataModelAddOptions,
+  is360ImageEventsAddOptions
+} from '../components/Reveal3DResources/typeGuards';
+import { type TaggedAddResourceOptions } from '../components/Reveal3DResources/types';
+
+export function createAddOptionsKey(model: TaggedAddResourceOptions): string {
+  if (model.type === 'cad' || model.type === 'pointcloud') {
+    return `${model.type}-${model.addOptions.modelId}-${model.addOptions.revisionId}`;
+  } else if (model.type === 'image360' && is360ImageDataModelAddOptions(model.addOptions)) {
+    return `${model.type}-${model.addOptions.externalId}/${model.addOptions.space}`;
+  } else if (model.type === 'image360' && is360ImageEventsAddOptions(model.addOptions)) {
+    return `${model.type}-${model.addOptions.siteId}`;
+  } else {
+    throw Error('Unrecognized add option type');
+  }
+}