Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Continue the architecture work #4531

Merged
merged 19 commits into from
May 27, 2024
Merged

(fix) Continue the architecture work #4531

merged 19 commits into from
May 27, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented May 25, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

  • Fix issues that @haakonflatval-cognite addressed (removed utility functions, classes, unclear code in DomainObjectChange, and commented roundIncrement())
  • Add comments around
  • Some renaming to make it even more consistent
  • Add some utility function in DomainObject that was missing
  • Moved some functions around
  • Fixed some minor user experience bugs during creation of measurements
  • Fixed some corner cases in the Axis visualization.
  • Added support for crop box, but on in UI yet.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nilscognite nilscognite requested a review from a team as a code owner May 25, 2024 09:34
@nilscognite nilscognite changed the title Continue the architecture work (fix) Continue the architecture work May 27, 2024
haakonflatval-cognite
haakonflatval-cognite approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

react-components/src/architecture/concrete/axis/AxisThreeView.ts Outdated Show resolved Hide resolved
@nilscognite nilscognite merged commit 37dbd67 into master May 27, 2024
14 checks passed
@nilscognite nilscognite deleted the np/architecture-continued branch May 27, 2024 14:36
@nilscognite nilscognite restored the np/architecture-continued branch May 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @haakonflatval-cognite