-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor (react-components): Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
changed the title
refactor: Used latest changes in Reveal (OnWheel, movment of Vector3Pool) + Final touch on the course material
refactor: Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material
Jun 10, 2024
nilscognite
changed the title
refactor: Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material
refactor (react-components): Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material
Jun 10, 2024
nilscognite
added
the
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
label
Jun 10, 2024
haakonflatval-cognite
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 But I'd like to have the comment I made addressed
Comment on lines
9
to
10
CanNotBeVisibleNow, // Can not be checked on, but it can be visible | ||
Disabled // Visible disabled | ||
Disabled // Visible disabled, not objects can be visible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names and comments of these two items were rather confusing 😅
…/reveal into np/use-latest-reveal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
<!-- refactoring production code, eg. renaming a variable -
https://cognitedata.atlassian.net/browse/
Description 📝