Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): react components rule core improvements to fix several issues in the Rule Builder time series selection/searching/selecting/filtering #4805

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

danpriori
Copy link
Contributor

@danpriori danpriori commented Oct 11, 2024

Type of change

Bug

Description 📝

This PR is bundled with PR: https://github.com/cognitedata/fusion/pull/8742 to fix several bugs related to fetching assets with timeseries, filtering timeseries types and selecting within the Rule Builder in 3d-management.
This PR specifically exposes some updated types, performs parallel timeseries fetching in functions and hooks, and other related improvements.

rulebuilder-timeseries.webm
rulebuilder-timeseries2.webm

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - a few comments

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…r-assets-without-timeseries-for-empty-query' into danpriori/BND3D-4356-rule-builder-assets-without-timeseries-for-empty-query
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about tests? Is there some simple mock data we could create to make this testable?

…r-assets-without-timeseries-for-empty-query' into danpriori/BND3D-4356-rule-builder-assets-without-timeseries-for-empty-query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants