Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Add 360 images/icons settings #4811

Merged
merged 29 commits into from
Oct 22, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Oct 17, 2024

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4638

Description 📝

  • Add some general purpose commands:, FractionSliderCommand and SectionCommand
  • Updated the mock settings with the new commands
  • Add value at the end of the slider label for all sliders. Fraction slider get a "value*100%" as label. Can call it percent, but the value itself goes from 0 to 1.
  • Move all point cloud settings into its own folder
  • Add all 360 commands settings given in the spec, in the folder: image360Collection
  • Note that I'm using the term from Reveal, not the test in UI. So Icons -> "Markers" in UI. If this is wanted to be in sync, as I normally would have done, I would changed from Icons to Marker in entire Reveal.
  • Updated the icons, so it uses the new icons I have ordered from Cogs

image

Todo:

Make sure it is translated in next version. Search for return @need-translation. I suggest we use this keyword in other places.

How has this been tested? 🔍

Not sure. Only tested the mock. It can be tested in Fusion, in another PR. https://github.com/cognitedata/fusion/pull/8847 Then it must be yalc'ed. I have tested it there.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few comments, but nothing that would block it, I think.

@nilscognite nilscognite merged commit 4ad3a9e into master Oct 22, 2024
14 checks passed
@nilscognite nilscognite deleted the np/360-settings-in-ui branch October 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants