-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): Add 360 images/icons settings #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpriori
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few comments, but nothing that would block it, I think.
react-components/src/architecture/base/commands/mocks/MockSettingsCommand.ts
Show resolved
Hide resolved
react-components/src/architecture/base/commands/FractionSliderCommand.ts
Outdated
Show resolved
Hide resolved
react-components/src/architecture/base/renderTarget/RevealRenderTarget.ts
Show resolved
Hide resolved
react-components/src/components/Architecture/SettingsButton.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4638
Description 📝
FractionSliderCommand
andSectionCommand
Todo:
Make sure it is translated in next version. Search for return
@need-translation
. I suggest we use this keyword in other places.How has this been tested? 🔍
Not sure. Only tested the mock. It can be tested in Fusion, in another PR. https://github.com/cognitedata/fusion/pull/8847 Then it must be yalc'ed. I have tested it there.
Checklist ☑️