Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong chapter was specified #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enox3
Copy link

@enox3 enox3 commented Nov 15, 2024

I found a bug, where the wrong chapter was specified, the link led to chapter 18, but the text stated it was chapter 17.

@Walentalien
Copy link

It seems that the same issue occurs later in the text as well and hasn't been addressed. Specifically:

Boxes provide only the indirection and heap allocation; they don’t have any other special capabilities, like those we’ll see with the other smart pointer types. They also don’t have the performance overhead that these special capabilities incur, so they can be useful in cases like the cons list where the indirection is the only feature we need. We’ll look at more use cases for boxes in Chapter 17, too.

willcrichton added a commit that referenced this pull request Jan 1, 2025
@squeakyboots
Copy link

Would this issue include the listings being mislabeled, or should another issue be raised for that?

For example, looking at the first code block of chapter 18.1 it's listed as "Listing 17-1" when it should be "Listing 18-1". In chapter 17.6 the text also states "Listing 17-TODO" which seems like it should be "Listing 17-42".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants