fix event names

coinbase · Jan 28, 2025 · bf660fe · bf660fe
1 parent f7528b7
commit bf660fe
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/src/internal/types.ts b/src/internal/types.ts
@@ -16,8 +16,8 @@ export enum AnalyticsEvent {
   WALLET_OPTION_SELECTED = 'walletOptionSelected',
 
   // Swap
-  SLIPPAGE_CHANGED = 'slippageChanged',
-  TOKEN_SELECTED = 'tokenSelected',
+  SWAP_SLIPPAGE_CHANGED = 'swapSlippageChanged',
+  SWAP_TOKEN_SELECTED = 'swapTokenSelected',
   SWAP_SUCCESS = 'swapSuccess',
 }
 
@@ -40,10 +40,10 @@ export type AnalyticsEventData = {
   };
 
   // Swap
-  [AnalyticsEvent.SLIPPAGE_CHANGED]: {
+  [AnalyticsEvent.SWAP_SLIPPAGE_CHANGED]: {
     slippage: number;
   };
-  [AnalyticsEvent.TOKEN_SELECTED]: {
+  [AnalyticsEvent.SWAP_TOKEN_SELECTED]: {
     token: string;
     source: 'from' | 'to';
   };

diff --git a/src/swap/components/SwapAmountInput.tsx b/src/swap/components/SwapAmountInput.tsx
@@ -56,7 +56,7 @@ export function SwapAmountInput({
 
   const handleSetToken = useCallback(
     (token: Token) => {
-      sendAnalytics(AnalyticsEvent.TOKEN_SELECTED, {
+      sendAnalytics(AnalyticsEvent.SWAP_TOKEN_SELECTED, {
         token: token.address,
         source: type,
       });

diff --git a/src/swap/components/SwapSettingsSlippageInput.tsx b/src/swap/components/SwapSettingsSlippageInput.tsx
@@ -39,6 +39,9 @@ export function SwapSettingsSlippageInput({
   const updateSlippage = useCallback(
     (newSlippage: number) => {
       if (newSlippage !== lifecycleStatus.statusData.maxSlippage) {
+        sendAnalytics(AnalyticsEvent.SWAP_SLIPPAGE_CHANGED, {
+          slippage: newSlippage,
+        });
         updateLifecycleStatus({
           statusName: 'slippageChange',
           statusData: {
@@ -47,7 +50,11 @@ export function SwapSettingsSlippageInput({
         });
       }
     },
-    [lifecycleStatus.statusData.maxSlippage, updateLifecycleStatus],
+    [
+      lifecycleStatus.statusData.maxSlippage,
+      updateLifecycleStatus,
+      sendAnalytics,
+    ],
   );
 
   // Handles user input for custom slippage.
@@ -58,14 +65,10 @@ export function SwapSettingsSlippageInput({
       const parsedSlippage = Number.parseFloat(newSlippage);
       const isValidNumber = !Number.isNaN(parsedSlippage);
 
-      sendAnalytics(AnalyticsEvent.SLIPPAGE_CHANGED, {
-        slippage: parsedSlippage,
-      });
-
       // Update slippage to parsed value if valid, otherwise set to 0
       updateSlippage(isValidNumber ? parsedSlippage : 0);
     },
-    [updateSlippage, sendAnalytics],
+    [updateSlippage],
   );
 
   // Toggles between auto and custom slippage settings