-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UI Primitives - FocusTrap, DismissableLayer, and Dialog. #1822
Merged
+800
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 16, 2025 01:32
0c5a293
to
e2c339c
Compare
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 16, 2025 02:00
9221e1a
to
408eb80
Compare
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 17, 2025 17:17
7dff1e1
to
c621053
Compare
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 17, 2025 17:38
c621053
to
87ed441
Compare
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 17, 2025 18:16
87ed441
to
3e91e32
Compare
cpcramer
force-pushed
the
paul/add-ui-primitives
branch
from
January 17, 2025 18:19
50b92d0
to
2d7bafc
Compare
dschlabach
approved these changes
Jan 17, 2025
brendan-defi
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Introduces new UI primitive components -
FocusTrap
,DismissableLayer
, andDialog
.FocusTrap
:DismissableLayer
:Dialog
:Design Principles:
Updated
WalletModal
to use the primitives for:Notes to reviewers
How has it been tested?