feat: more send utilities #1892
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/api/buildSendTransaction.ts
Outdated
| to: tokenAddress, | ||
| data: transferCallData, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
why does this return an array?
There was a problem hiding this comment.
it doesn't need to, I'll just return the object
| } | ||
| const parsedAmount = parseUnits(amount, token.decimals); | ||
| return { | ||
| calls: buildSendTransaction({ |
There was a problem hiding this comment.
this will be a weird response format if there's an error
| } | ||
| } else if (isAddress(input, { strict: false })) { | ||
| return input; | ||
| } |
There was a problem hiding this comment.
nit: if isAddress then no need to check if its isBasename or isEns? moving this first could remove the else if and short circuit faster
There was a problem hiding this comment.
makes sense, updated
src/api/buildSendTransaction.ts
Outdated
| } catch (error) { | ||
| return { | ||
| code: 'AmBSeTa01', // Api Module Build Send Transaction Error 01 | ||
| error: `Something went wrong: ${error}`, |
There was a problem hiding this comment.
could probably just return error here, i think its implicit that something went wrong
There was a problem hiding this comment.
ack, will update to Error: ${error}
| return sendTransaction; | ||
| } | ||
|
|
||
| const parsedAmount = parseUnits(amount.toString(), token.decimals); |
There was a problem hiding this comment.
nit: amount should already be a string?
There was a problem hiding this comment.
yep, you're right, removing the method
What changed? Why?
buildSendTransactionAPI endpointuseSendTransactionhookvalidateAddressInputwallet utilNotes to reviewers
How has it been tested?