chore: move amount input #1893
Merged
chore: move amount input #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rustam-cb
approved these changes
Jan 28, 2025
dschlabach
reviewed
Jan 29, 2025
| /** autocomplete attribute handles browser autocomplete, defaults to 'off' */ | ||
| autoComplete?: string; | ||
| /** data-1p-ignore attribute handles password manager autocomplete, defaults to true */ | ||
| 'data-1p-ignore'?: boolean; |
There was a problem hiding this comment.
Is there ever a case where we don't want to ignore it? I'd argue for just removing it completely and setting our inputs to always ignore
There was a problem hiding this comment.
i think it's probably right that we always want to ignore, but since this is internal i figured i'd leave us the option. wdyt?
There was a problem hiding this comment.
If it's internal + not planned to be used I'd rather remove it since it keeps the props more concise, but I won't block on this issue
There was a problem hiding this comment.
thanks, i'll create ticket to remove
dschlabach
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
AmountInput,AmountInputTypeSwitch, andCurrencyLabeltosrc/internaluseInputResizetosrc/internalFundCardcomponents with the new internal versionsNotes to reviewers
How has it been tested?