chore: Update IsBaseOptions and IsEthereumOptions naming convention #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
cpcramer
force-pushed
the
paul/update-isOptions-type-PascalCase
branch
from
fdcbc19 to
4b51aa4
Compare
cpcramer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Interfaces and Types should use
PascalCase, we currently are usingcamelCasefor typeisBaseOptionsandisEthereumOptions.Updating types to use
PascalCaseto remain consistent across our library.Note that this is a breaking change.
This naming convention issue was brought up in this PR fix: types naming convention
Notes to reviewers
How has it been tested?