Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix type typo, add sidebar #1921

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

brendan-defi
Copy link
Contributor

What changed? Why?

  • added getPortfolios documentation to sidebar
  • fixed typo in type and type link

Notes to reviewers

How has it been tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 10:44pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 10:44pm

@cpcramer
Copy link
Contributor

cpcramer commented Feb 3, 2025

nit: title should have docs prefix

@cpcramer
Copy link
Contributor

cpcramer commented Feb 3, 2025

Also, this is great! We should highlight the new sidebar with a changeset 😄

@brendan-defi brendan-defi changed the title chore: fix type typo, add sidebar docs: fix type typo, add sidebar Feb 4, 2025
@brendan-defi
Copy link
Contributor Author

nit: title should have docs prefix

my bad, forgot the convention. changed

@brendan-defi brendan-defi merged commit d465c49 into main Feb 4, 2025
16 checks passed
@brendan-defi brendan-defi deleted the chore/getportolios-sidebar branch February 4, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants