add ownerCount method #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimumsec
reviewed
Apr 19, 2024
xenoliss
reviewed
Apr 19, 2024
| @@ -137,8 +136,7 @@ contract MultiOwnable { | |||
| /// @param index The index of the owner to be removed. | |||
| /// @param owner The ABI encoded bytes of the owner to be removed. | |||
| function removeLastOwner(uint256 index, bytes calldata owner) external virtual onlyOwner { | |||
| MultiOwnableStorage storage $ = _getMultiOwnableStorage(); | |||
| uint256 ownersRemaining = $.nextOwnerIndex - $.removedOwnersCount; | |||
| uint256 ownersRemaining = ownerCount(); | |||
There was a problem hiding this comment.
I think we can get rid of this stack variable and do the same thing as in `removeOwnerAtIndex():
if (ownerCount() > 1) {
revert NotLastOwner(ownersRemaining);
}There was a problem hiding this comment.
but then I would need to call ownerCount again here revert NotLastOwner(ownersRemaining);
There was a problem hiding this comment.
Would be revert NotLastOwner(ownerCount());
There was a problem hiding this comment.
Oh yes right, I missed that.
There was a problem hiding this comment.
But yeah could debate: do we penalize gas on the non revert path in order to save on revert?
xenoliss
approved these changes
Apr 19, 2024
|
Review Error for xenoliss @ 2024-04-19 17:06:50 UTC |
wilsoncusack
force-pushed
the
wilson/ownerCount
branch
from
af8384c to
5e90754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience method https://github.com/cantinasec/review-coinbase-smartwallet/issues/5