fix: 🐛 migration could run on non cluster instance

coingaming · Aug 30, 2024 · 756839e · 756839e
1 parent fc1e0d5
commit 756839e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/plausible/data_migration/versioned_sessions.ex b/lib/plausible/data_migration/versioned_sessions.ex
@@ -22,7 +22,13 @@ defmodule Plausible.DataMigration.VersionedSessions do
     unique_suffix = Timex.now() |> Timex.format!(@suffix_format)
 
     cluster? = Plausible.MigrationUtils.clustered_table?("sessions_v2")
-    cluster_name = Plausible.MigrationUtils.cluster_name()
+
+    cluster_name =
+      if cluster? do
+        Plausible.MigrationUtils.cluster_name()
+      else
+        nil
+      end
 
     {:ok, %{rows: partitions}} = run_sql("list-partitions")
     partitions = Enum.map(partitions, fn [part] -> part end)

diff --git a/priv/ingest_repo/migrations/20240423094014_add_imported_custom_events.exs b/priv/ingest_repo/migrations/20240423094014_add_imported_custom_events.exs
@@ -4,7 +4,14 @@ defmodule Plausible.IngestRepo.Migrations.AddImportedCustomEvents do
   def change do
     # NOTE: Using another table for determining cluster presence
     on_cluster = Plausible.MigrationUtils.on_cluster_statement("imported_pages")
-    cluster_name = Plausible.MigrationUtils.cluster_name()
+    cluster? = Plausible.MigrationUtils.clustered_table?("imported_pages")
+
+    cluster_name =
+      if cluster? do
+        Plausible.MigrationUtils.cluster_name()
+      else
+        nil
+      end
 
     settings =
       if Plausible.MigrationUtils.clustered_table?("imported_pages") do