Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session events are back [IS-23] #9

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: session events are back [IS-23] #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75dec1
fix: session events are back [IS-23]
phgrey Jul 31, 2024
680ba01
tests fixing
phgrey Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/js/dashboard/stats/live_view/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import ImportedQueryUnsupportedWarning from '../imported-query-unsupported-warni
import Properties from '../behaviours/props';

const labelFor = {
'phx-event': 'LiveView Events',
'phx-push': 'Custom Server Events',
'phx-event': 'LiveView Sessions',
'phx-push': 'Server Events',
'js-submit': 'Form Submits'
}

Expand Down
2 changes: 1 addition & 1 deletion tracker/src/plausible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
window.addEventListener('phx:navigate', info => trigger('pageview', {u: info.detail.href}));
{{/unless}}

['phx-click', 'phx-change', 'phx-submit', 'phx-viewport-top', 'phx-viewport-bottom', 'phx-mounted', 'phx-connected', 'phx-disconnected'].map((name) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you regression tested current live view features? phx-click and events?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

['phx:page-loading-start', 'phx:page-loading-stop'].map((name) => {
window.addEventListener(name, info => trigger('phx-event', {props: {event: name, detail: new URLSearchParams(info.detail || {}).toString()}}));
});

Expand Down
Loading