Add tests for dependency constraints #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests evaluate the code which shows a message to the user when a dependency with a version constraint is not satisfied by the version of the dependency which is present.
cottsay
force-pushed
the
cottsay/dep-constraint-tests
branch
from
b3cd3a0
to
7429bfb
Compare
cottsay
commented
Feb 18, 2024
| ignore:pkg_resources is deprecated as an API::flake8_import_order | ||
| ignore:pkg_resources is deprecated as an API:: |
There was a problem hiding this comment.
This needed to be loosened because we're actually running the code in the tests now. I'm going to follow up with a change that will break our dependency on pkg_resources directly, at which point I'll revert this hunk.
christophebedard
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests evaluate the code which shows a message to the user when a dependency with a version constraint is not satisfied by the version of the dependency which is present.
This brings us to 100% coverage in https://github.com/colcon/colcon-package-information/blob/master/colcon_package_information/package_augmentation/check_dependency_constraint.py