Add --packages-select-under-path mechanism #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package selection mechanism deselects packages which do not reside (recusively) within one of the given paths.
nuclearsandwich
approved these changes
Feb 16, 2024
| if args.packages_select_under_path: | ||
| packages_select_under_path = { | ||
| path for path in args.packages_select_under_path | ||
| if path.is_dir() |
There was a problem hiding this comment.
I'm not sure whether this would be too much babysitting but would it make sense to warn if we find an arg that's a file not a directory?
There was a problem hiding this comment.
The warning is on line 31 :)
There was a problem hiding this comment.
You know, I saw that and thought "yeah we warn in this case but not this one" and they're the same case. 🤦🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package selection mechanism deselects packages which do not reside (recursively) within one of the given paths.
We could probably add skip and up-to variants, but I'm not motivated to add them quite yet. PRs welcome.