Validate array uniqueness #2672

joaoGabriel55 · 2023-08-21T13:29:35Z

From discussion: #2316

TODO

Implement array of primitives uniqueness
Implement array of complex objects uniqueness

Thanks for the help: @ramos-ph and @fwoelffel

netlify · 2023-08-21T13:29:41Z

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

Name	Link
🔨 Latest commit	`68d83b7`
🔍 Latest deploy log	https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/66283b3cf8e5c5000892af19
😎 Deploy Preview	https://deploy-preview-2672--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

joaoGabriel55 · 2023-08-21T14:06:41Z

What suggestions do you have for array of complex objects uniqueness? I have one that would be make the objects elements from array flatten to simplifies the comparison between.

aarontravass · 2023-08-21T16:10:39Z

What suggestions do you have for array of complex objects uniqueness? I have one that would be make the objects elements from array flatten to simplifies the comparison between.

Class-validator seems to be doing a simple comparison

https://github.com/typestack/class-validator/blob/262a3c6369b9a9fc81846a39b62b6a2a21bd8fab/src/decorator/array/ArrayUnique.ts#L7-L20

joaoGabriel55 · 2023-08-31T20:39:11Z

@colinhacks could you take a look, when you have a free time?

aarontravass · 2023-09-14T22:52:09Z

@joaoGabriel55 As discussed here, #2316 (reply in thread), would it be possible to add an options which would display duplicate items?

joaoGabriel55 · 2023-09-15T11:46:28Z

@joaoGabriel55 As discussed here, #2316 (reply in thread), would it be possible to add an options which would display duplicate items?

yeah!

src/types.ts

fwoelffel · 2024-02-14T09:40:43Z

@colinhacks any thoughts about this?

fwoelffel · 2024-02-14T09:42:23Z

deno/lib/types.ts

@@ -1975,6 +1975,11 @@ export interface ZodArrayDef<T extends ZodTypeAny = ZodTypeAny>
  exactLength: { value: number; message?: string } | null;
  minLength: { value: number; message?: string } | null;
  maxLength: { value: number; message?: string } | null;
+  uniqueness: {
+    identifier?: ArrayUniqueIdentifier;
+    message?: string | ((duplicateElements: any) => string);


Suggested change

message?: string | ((duplicateElements: any) => string);

message?: string | ((duplicateElements: T[]) => string);

I tried this, but some types of errors like this:

Type '{ [k in keyof T]: ZodOptional<T[k]>; }' does not satisfy the constraint 'ZodRawShape'. Type 'ZodOptional<T[k]>' is not assignable to type 'ZodTypeAny'. The types returned by 'refine(...).refine(...).optional()' are incompatible between these types. Type 'ZodOptional<ZodEffects<ZodEffects<ZodOptional<T[k]>, any, T[k]["_input"] | undefined>, any, T[k]["_input"] | undefined>>' is not assignable to type 'ZodOptional<ZodEffects<ZodEffects<ZodType<any, any, any>, any, any>, any, any>>'. Type 'ZodEffects<ZodType<any, any, any>, any, any>' is not assignable to type 'ZodEffects<ZodOptional<T[k]>, any, T[k]["_input"] | undefined>'.

Type 'Options[number]' does not satisfy the constraint 'ZodType<any, any, any>'.ts(2344)

I'll try to have a look at this during the weekend ;)

fwoelffel · 2024-02-16T15:59:12Z

src/types.ts

        ? params.message
-        : errorUtil.toString(params.message);
+        : errorUtil.toString(params?.message);


Suggested change

: errorUtil.toString(params?.message);

: errorUtil.toString(params.message);

I need to put this ? because the params can be not passed (undefined) on the .unique method.

colinhacks · 2024-04-23T22:50:19Z

Thanks! I like this a lot, especially identifier. I'm merging this into the v4 branch. Some version of this will land in Zod 4, but — as a heads up — it may be a while, and this feature/API will likely undergo some changes in the interim.

* feat: implement primitive array uniqueness * chore: update yarn.lock * feat: implement array of complex objects uniqueness * chore: rollback yarn.lock * refactor: minor update _arrayUnique * chore: minor change yarn.lock * feat: implement custom message support * feat: add showDuplicates param * chore: TS types update * chore: TS types II * refactor: ArrayMessageFunction * refactor: simplify array uniqueness implementation * docs: add documentation for array uniqueness * Regen lock * Fix readme --------- Co-authored-by: Frederic Woelffel <[email protected]> Co-authored-by: Colin McDonnell <[email protected]>

MentalGear · 2024-09-20T18:26:01Z

Cool, but I do not get why the most idiomatic approach, z.array(z.string()).unique(), is not supported ?
@joaoGabriel55

fwoelffel · 2024-10-09T07:36:27Z

Cool, but I do not get why the most idiomatic approach, z.array(z.string()).unique(), is not supported ? @joaoGabriel55

Maybe I'm mistaken, but z.array(z.string()).unique() is supported 🤔

aarontravass reviewed Sep 19, 2023

View reviewed changes

src/types.ts Outdated Show resolved Hide resolved

fwoelffel suggested changes Feb 14, 2024

View reviewed changes

fwoelffel suggested changes Feb 16, 2024

View reviewed changes

fwoelffel mentioned this pull request Feb 18, 2024

Validate array uniqueness joaoGabriel55/zod#1

Merged

fwoelffel approved these changes Feb 20, 2024

View reviewed changes

joaoGabriel55 and others added 15 commits April 23, 2024 15:40

feat: implement primitive array uniqueness

eadf65f

chore: update yarn.lock

f8828da

feat: implement array of complex objects uniqueness

f295bf1

chore: rollback yarn.lock

2055a5f

refactor: minor update _arrayUnique

6d83361

chore: minor change yarn.lock

999ed89

feat: implement custom message support

1e51ae0

feat: add showDuplicates param

79e8d04

chore: TS types update

e20054f

chore: TS types II

6babf4e

refactor: ArrayMessageFunction

3543c60

refactor: simplify array uniqueness implementation

e7fbadd

docs: add documentation for array uniqueness

fa6b0ba

Regen lock

9173cf9

Fix readme

68d83b7

colinhacks force-pushed the validate-array-uniqueness branch from 148dfbd to 68d83b7 Compare April 23, 2024 22:50

colinhacks changed the base branch from master to v4 April 23, 2024 22:50

colinhacks merged commit 0e4583d into colinhacks:v4 Apr 23, 2024
20 checks passed

EllAchE mentioned this pull request May 6, 2024

Return data in safeparse EllAchE/zod#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate array uniqueness #2672

Validate array uniqueness #2672

joaoGabriel55 commented Aug 21, 2023 •

edited

Loading

netlify bot commented Aug 21, 2023 •

edited

Loading

joaoGabriel55 commented Aug 21, 2023

aarontravass commented Aug 21, 2023

joaoGabriel55 commented Aug 31, 2023

aarontravass commented Sep 14, 2023

joaoGabriel55 commented Sep 15, 2023

fwoelffel commented Feb 14, 2024

fwoelffel Feb 14, 2024

joaoGabriel55 Feb 14, 2024

fwoelffel Feb 16, 2024

fwoelffel Feb 16, 2024

joaoGabriel55 Feb 17, 2024

fwoelffel Feb 18, 2024

colinhacks commented Apr 23, 2024 •

edited

Loading

MentalGear commented Sep 20, 2024

fwoelffel commented Oct 9, 2024

	message?: string \| ((duplicateElements: any) => string);
	message?: string \| ((duplicateElements: T[]) => string);

	: errorUtil.toString(params?.message);
	: errorUtil.toString(params.message);

Validate array uniqueness #2672

Validate array uniqueness #2672

Conversation

joaoGabriel55 commented Aug 21, 2023 • edited Loading

netlify bot commented Aug 21, 2023 • edited Loading

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

joaoGabriel55 commented Aug 21, 2023

aarontravass commented Aug 21, 2023

joaoGabriel55 commented Aug 31, 2023

aarontravass commented Sep 14, 2023

joaoGabriel55 commented Sep 15, 2023

fwoelffel commented Feb 14, 2024

fwoelffel Feb 14, 2024

Choose a reason for hiding this comment

joaoGabriel55 Feb 14, 2024

Choose a reason for hiding this comment

fwoelffel Feb 16, 2024

Choose a reason for hiding this comment

fwoelffel Feb 16, 2024

Choose a reason for hiding this comment

joaoGabriel55 Feb 17, 2024

Choose a reason for hiding this comment

fwoelffel Feb 18, 2024

Choose a reason for hiding this comment

colinhacks commented Apr 23, 2024 • edited Loading

MentalGear commented Sep 20, 2024

fwoelffel commented Oct 9, 2024

joaoGabriel55 commented Aug 21, 2023 •

edited

Loading

netlify bot commented Aug 21, 2023 •

edited

Loading

colinhacks commented Apr 23, 2024 •

edited

Loading