Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy switch, Vitest is great.
Benchmarking
With Jest +
ts-jest
— 4000msWith Vitest — 1.3s
Issues
vitest.workspace.ts
...another workspace fileMy only complaint is the need for a
vitest.workspace.ts
. It would be nice if this read from"workspaces"
in package.json. I couldn't find a satisfactory discussion on this subject on the Vitest repo but maybe I missed something.I have the same complaint with pnpm. Why do these tools all need their own workspace files? If the performance penalty from parsing a bunch of
package.json
s is a factor, maybe these tools could converge on a convention likeworkspace.yml
.typecheck.exclude
doesn't seem to work as expectedI couldn't get typechecking to include my test files and exclude the files in
zod/deno/lib
. The globs definitely aren't resolving in a normal way. I ended up just settingignoreSourceErrors: true
which isn't a good long term solution. There's been some confusion about Vite's approach to glob expansion in the past: vitest-dev/vitest#4767If anyone wants to repro this, disable
ignoreSourceErrors
invitest.root.ts
and runpnpm test
. Feel free to play around with some different include/exclude globs.