Adding support for RedisCluster (phpredis extension)

[JacobBrownAustin]

related pull request:
colinmollenhour/php-redis-session-abstract#62

[colinmollenhour]

Thanks for the PR! I think this should probably just replace Credis_Cluster since it was never completed and would need a lot of work and having both would be confusing. Would you mind removing that, updating the README and add a basic PHPUnit test? Also, I think the constructor should probably throw an exception if the phpredis extension is not present.

[infowolfe]

@JacobBrownAustin thank you for this! Magento has been missing support for redis 6 for 4 years.

[JacobBrownAustin]

Thanks for the PR! I think this should probably just replace Credis_Cluster since it was never completed and would need a lot of work and having both would be confusing. Would you mind removing that, updating the README and add a basic PHPUnit test? Also, I think the constructor should probably throw an exception if the phpredis extension is not present.

Those all sound great. I'll update this soon.

[JacobBrownAustin]

@colinmollenhour , the Credis_Sentinel also uses Credis_Cluster. What should be done about that?

https://github.com/colinmollenhour/credis/blob/master/Sentinel.php#L312
https://github.com/colinmollenhour/credis/blob/master/Sentinel.php#L268

[JacobBrownAustin]

@colinmollenhour , because the new class is basically just an adapter to the php redis extension, there's not much logic to test in the class itself as a unit test, so I'll add a Redis cluster to the docker compose to test it more of an integration test.

[colinmollenhour]

@colinmollenhour , the Credis_Sentinel also uses Credis_Cluster. What should be done about that?

Both of those methods are marked as deprecated so they can be removed. The new version will get a major version bump already.

[colinmollenhour]

@colinmollenhour , because the new class is basically just an adapter to the php redis extension, there's not much logic to test in the class itself as a unit test, so I'll add a Redis cluster to the docker compose to test it more of an integration test.

Sounds good, thanks!

[infowolfe]

@JacobBrownAustin any movement on this?