Introduce SIGKILL to ensure process has terminated after MAXWAIT #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lusitania <[email protected]>
tokkee
requested changes
Jan 5, 2017
| echo -n " ." | ||
|
|
||
| if test $i -gt $MAXWAIT; then | ||
| if (( $i > $MAXWAIT )); then |
There was a problem hiding this comment.
This is an unrelated change. Please move it into a separate commit.
| @@ -12,6 +12,10 @@ USE_COLLECTDMON=1 | |||
| # default: 30 | |||
| MAXWAIT=30 | |||
|
|
|||
| # try a terminal kill -9 if the process refuses to shut down | |||
| # default: 0 | |||
| declare -i USE_SIGKILL=1 | |||
There was a problem hiding this comment.
This is a very generic name, missing the context of where this would be applied. Can you think of something better? I don't have a good idea myself yet but something along the lines of KILL_AFTER_WAIT or similar.
| @@ -12,6 +12,10 @@ USE_COLLECTDMON=1 | |||
| # default: 30 | |||
| MAXWAIT=30 | |||
|
|
|||
| # try a terminal kill -9 if the process refuses to shut down | |||
| # default: 0 | |||
| declare -i USE_SIGKILL=1 | |||
There was a problem hiding this comment.
This will set the default value to 1 instead of 0.
| @@ -12,6 +12,10 @@ USE_COLLECTDMON=1 | |||
| # default: 30 | |||
| MAXWAIT=30 | |||
|
|
|||
| # try a terminal kill -9 if the process refuses to shut down | |||
| # default: 0 | |||
| declare -i USE_SIGKILL=1 | |||
There was a problem hiding this comment.
For consistency with other settings, please don't use declare. I'm fine with a separate commit changing this globally.
|
Any update on this? On second thought, I think it would be better to convert this code to use start-stop-daemon's --retry flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the init script to SIGKILL the process group of the service after MAXWAIT has expired. The feature is set in
/etc/default/collectdand enabled by default: