CB-27: Update field for numberOfObjects display #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates the field for numberOfObjects to use objectCountGroupList
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/jira/software/c/projects/CB/issues/CB-27
In cspace 8.0
numberOfObjects
has been replaced with a repeating group,objectCountGroupList
. The old value is now inobjectCount
, which this updates the detail field to read from.How should this be tested? Do these changes have associated tests?
Setting this up is kind of involved, so let me know if there are any mistakes:
Holdings
display for the collectionobject match the object count set from the cspace uiDependencies for merging? Releasing to production?
None, though we might want to revisit the display to see if we want to show any of the other object count group fields.
Has the public browser documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested locally