Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Python 3.7 compatibility by not using functools.cached_property. #69

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mauritsvanrees
Copy link
Member

Note that Python 3.7 is end of life, and this add-on is not tested on it. But this was an easy fix.

Note that Python 3.7 is end of life, and this add-on is not tested on it.
But this was an easy fix.
Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update setup.py with a python_requires=">=3.8" according the classifiers and that Python 3.7 has reached its end of life.

@mauritsvanrees
Copy link
Member Author

Let's update setup.py with a python_requires=">=3.8" according the classifiers and that Python 3.7 has reached its end of life.

The problem I see with such a change, is that this makes it impossible to install this package on Python 3.7, even though it would actually work, after this PR anyway.

In core Plone I am inclined to use the classifiers for the versions that we recommend, and to keep python_requires more lenient. For example, in Products.CMFPlone on branch 5.2.x, the setup.py has classifiers only for Python 2.7 and 3.8, but python_requires still accepts Python 3.6 and 3.7.

But if you still prefer, I am happy to change it here.

In fact, I would be happy to drop Plone 5.2 support.

@ksuess
Copy link
Member

ksuess commented Dec 18, 2023

Let's update setup.py with a python_requires=">=3.8" according the classifiers and that Python 3.7 has reached its end of life.

The problem I see with such a change, is that this makes it impossible to install this package on Python 3.7, even though it would actually work, after this PR anyway.

In core Plone I am inclined to use the classifiers for the versions that we recommend, and to keep python_requires more lenient. For example, in Products.CMFPlone on branch 5.2.x, the setup.py has classifiers only for Python 2.7 and 3.8, but python_requires still accepts Python 3.6 and 3.7.

But if you still prefer, I am happy to change it here.

Ah, OK, now I am aware that it in fact makes sense to use the classifiers for recommendations. But keep the range of required versions wider. Thanks for the hint. I retract my change request.

@ksuess
Copy link
Member

ksuess commented Dec 18, 2023

In fact, I would be happy to drop Plone 5.2 support.

+1 from me.

@mauritsvanrees mauritsvanrees merged commit 8adcfc8 into master Dec 19, 2023
4 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-python37 branch December 19, 2023 15:31
@mauritsvanrees
Copy link
Member Author

I have released 2.1.1 with this fix.
We can see about dropping 5.2 support later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants