add GitLab CI/CD support #135
Conversation
erral
requested review from
ericof,
ksuess,
jensens,
sneridagh,
stevepiercy,
Fosten,
fredvd and
davisagli
as code owners
- Renamed to a fully-spelled name - Use the now preferred for several years ED25519 SSH key, instead of RSA - Mostly style guide formatting, grammar, and MyST that is tedious to go through a review cycle
|
No problem on documenting how to create ED25519 keys. But we are creating RSA keys for the deployment... |
|
@erral OK, but should we use RSA or ED25519 going forward? My sysadmin required that I regenerate my SSH keys to use ED25519 for our GitLab instance. I assume this is now a best practice, as the GitLab docs say this is the way forward for now. |
|
OK. I will update my PR to document how to use EDD25519 keys. I will add a new PRto create and use those keys by default. |
|
I already added the commands for ED25519 keys in my commit to this PR. Please take a look, and let me know if it needs revision. |
The changes are OK! |
|
@stevepiercy I have added a note in the section where I suggest to create a new SSH key, saying that one can reuse the one created by the server setup command. |
There was a problem hiding this comment.
I think we also need to update a couple of other files.
README.md under Project Generation Options:
| `github_organization` | Used for GitHub and Docker repositories. | **collective** |
to:
| `github_organization` | Used for GitHub, GitLab, and Docker repositories. | **collective** |
https://github.com/collective/cookiecutter-plone-starter/blob/main/cookiecutter.json#L99
"github_organization": "GitHub Username or Organization",
to:
"github_organization": "GitHub or GitLab Username or Organization",
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
I have added a
.gitlab-ci.ymlfile to provide deployment configuration for those using GitLab CI/CD.I have also added a README explaining how to configure it.