Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run the template without docker #143

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

davisagli
Copy link
Member

Fixes #79

This makes it possible to run the template even if Docker is not installed or not running. In that case the "make format" step will log an error, but won't prevent the template from completing.

@jensens
Copy link
Member

jensens commented Apr 16, 2024

+1 for not failing.
Is there any reason to not use Precommit or alike, like everywhere else? Dependening on Docker just to lint/format is a bit much IMHO.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a first small improvement.

@davisagli
Copy link
Member Author

Is there any reason to not use Precommit or alike, like everywhere else? Dependening on Docker just to lint/format is a bit much IMHO.

@jensens I was going for a quick fix, but Érico and Steve also made this point after I submitted this and I think we will give it a try.

@davisagli davisagli merged commit 549bf4e into main Apr 16, 2024
5 checks passed
@davisagli davisagli deleted the optional-docker branch April 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post hook fails if Docker is not running
3 participants