Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Keycloak Group Enumeration and Group Introspection #43

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ericof
Copy link
Member

@ericof ericof commented Dec 22, 2023

Fixes #42

@ericof ericof marked this pull request as ready for review February 28, 2024 01:34
@erral
Copy link
Member

erral commented Mar 4, 2024

I am not sure whether this plugin is the place to implement the specifics for Keycloak group enumeration or pas.plugins.keycloakgroupenumeration would be a better place.

@ericof
Copy link
Member Author

ericof commented Mar 4, 2024

@erral Let me check how feasible it is to extract just the group support to a new package, meanwhile @mpeeters I wait for your feedback ;-)

@mpeeters
Copy link
Member

mpeeters commented Mar 5, 2024

@ericof I tried the new changes and I still have the same issue, my user have the groups and roles (listed in the Plone control panel), but those roles are not effective, and thus, my user does not have any related permissions (checked with manage_access)

Regarding performance, it is way better than before.

@ericof
Copy link
Member Author

ericof commented Mar 5, 2024

Interesting 🤔, I will double check what could be the issue with the roles not being applied

@ericof ericof force-pushed the issue-42-group-enumeration branch from 8da5fdc to 596965c Compare March 5, 2024 23:15
@ericof
Copy link
Member Author

ericof commented Mar 5, 2024

@erral, @mpeeters: Please take a look at the updated version -- that only mentions pas.plugins.keycloakgroups

Copy link
Collaborator

@mamico mamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed about moving the functionality to a separate product.

@ericof ericof merged commit 7fa4aa6 into main Mar 12, 2024
5 checks passed
@ericof ericof deleted the issue-42-group-enumeration branch March 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Group Enumeration
4 participants