Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add celery integration and upgrade javascript #52

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

runyaga
Copy link

@runyaga runyaga commented Aug 9, 2018

  • Upgrade to latest mediaelementjs
  • Add collective.celery integration (requires latest collective.celery pull request)
  • If x-send-file is being used opt out of that on stream view (requires latest of that package as well)

@djay
Copy link
Member

djay commented Aug 10, 2018

@runyaga would have been nice to split that into different PRs.
I'm assuming it still works with p.a.async right?

@djay
Copy link
Member

djay commented Aug 10, 2018

@runyaga also whats the reason to opt out of x-send-file? I specifically made it work with wc.media if I remember it right?

@runyaga
Copy link
Author

runyaga commented Aug 13, 2018

yes it should still works with p.a.async.
we only have to disable x-sendfile for the streaming view.
when GET the media file directly it uses x-sendfile
will not be able to break up until smaller PR for awhile.

@djay
Copy link
Member

djay commented Aug 14, 2018

@runyaga why do you want to disable x-sendfile for the streaming view. We used it successfully with streaming and it enabled much better scaling due to HAproxy or other loadbalancers not being able to know that zope is capable of handling another request even if it is streaming.

@runyaga
Copy link
Author

runyaga commented Sep 6, 2018

@djay nmaier/mod_xsendfile#37 appears others are having issues with range support. we cant get range support working. we hope to move to nginx in the near future for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants