fix benchmarks, add codspeed instead of pytest-benchmark, add action …

…and gh workflow
collerek · Feb 7, 2024 · 80a93b4 · 80a93b4
1 parent ab85c81
commit 80a93b4
Show file tree

Hide file tree

Showing 8 changed files with 405 additions and 386 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -0,0 +1,40 @@
+name: codspeed-benchmarks
+
+on:
+  push:
+    branches:
+      - "master" # or "master"
+  pull_request:
+    branches: [ master, pydantic_v2 ]
+  # `workflow_dispatch` allows CodSpeed to trigger backtest
+  # performance analysis in order to generate initial data.
+  workflow_dispatch:
+
+jobs:
+  benchmarks:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v3
+        with:
+          python-version: "3.11"
+
+      - name: Install Poetry
+        uses: snok/[email protected]
+        with:
+          version: 1.4.2
+          virtualenvs-create: false
+
+      - name: Poetry details
+        run: |
+          poetry --version
+          poetry config --list
+
+      - name: Install dependencies
+        run: poetry install --extras "all"
+
+      - name: Run benchmarks
+        uses: CodSpeedHQ/action@v2
+        with:
+          token: ${{ secrets.CODSPEED_TOKEN }}
+          run: poetry run pytest benchmarks/ --codspeed
diff --git a/benchmarks/conftest.py b/benchmarks/conftest.py
@@ -83,7 +83,7 @@ async def authors_in_db(num_models: int):
     authors = [
         Author(
             name="".join(random.sample(string.ascii_letters, 5)),
-            score=random.random() * 100,
+            score=int(random.random() * 100),
         )
         for i in range(0, num_models)
     ]

diff --git a/benchmarks/test_benchmark_bulk_create.py b/benchmarks/test_benchmark_bulk_create.py
@@ -15,7 +15,7 @@ async def make_and_insert(num_models: int):
         authors = [
             Author(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             for i in range(0, num_models)
         ]

diff --git a/benchmarks/test_benchmark_create.py b/benchmarks/test_benchmark_create.py
@@ -16,7 +16,7 @@ async def create(num_models: int):
         for idx in range(0, num_models):
             author = await Author.objects.create(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             authors.append(author)
         return authors
@@ -62,7 +62,7 @@ async def get_or_create(num_models: int):
         for idx in range(0, num_models):
             author, created = await Author.objects.get_or_create(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             assert created
             authors.append(author)
@@ -81,7 +81,7 @@ async def update_or_create(num_models: int):
         for idx in range(0, num_models):
             author = await Author.objects.update_or_create(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             authors.append(author)
         return authors

diff --git a/benchmarks/test_benchmark_init.py b/benchmarks/test_benchmark_init.py
@@ -15,13 +15,13 @@ async def initialize_models(num_models: int):
         authors = [
             Author(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             for i in range(0, num_models)
         ]
         assert len(authors) == num_models
 
-    await initialize_models(num_models)
+    _ = initialize_models(num_models)
 
 
 @pytest.mark.parametrize("num_models", [10, 20, 40])

diff --git a/benchmarks/test_benchmark_save.py b/benchmarks/test_benchmark_save.py
@@ -15,7 +15,7 @@ async def make_and_insert(num_models: int):
         authors = [
             Author(
                 name="".join(random.sample(string.ascii_letters, 5)),
-                score=random.random() * 100,
+                score=int(random.random() * 100),
             )
             for i in range(0, num_models)
         ]

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -125,13 +125,13 @@ dataclasses = { version = ">=0.6.0,<0.8 || >0.8,<1.0.0" }
 
 # Performance testing
 yappi = "^1.4.0"
-pytest-benchmark = "^4.0.0"
 nest-asyncio = "^1.5.6"
 
 pre-commit = "^2.21.0"
 httpx = "^0.24.1"
 asgi-lifespan = "^2.1.0"
 pydantic-extra-types = "^2.5.0"
+pytest-codspeed = "^2.2.0"
 
 
 [build-system]