Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parentheses to get_pydantic call #1344

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Add missing parentheses to get_pydantic call #1344

merged 1 commit into from
Jun 9, 2024

Conversation

Chaoyingz
Copy link
Contributor

No description provided.

@collerek
Copy link
Owner

collerek commented Jun 9, 2024

Thanks!

@collerek collerek merged commit fbde811 into collerek:master Jun 9, 2024
12 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 9, 2024

CodSpeed Performance Report

Merging #1344 will degrade performances by 12.83%

Comparing Chaoyingz:patch-1 (99dd161) with master (7f3149d)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 82 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master Chaoyingz:patch-1 Change
❌ test_deleting_individually[10] 8.6 ms 9.9 ms -12.83%
⚡ test_first[250] 3.5 ms 2.6 ms +33.87%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaoyingz @collerek