Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index error on double addition of the same related model #1346

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

collerek
Copy link
Owner

@collerek collerek commented Jun 9, 2024

Resolves: #1335

Copy link

codspeed-hq bot commented Jun 9, 2024

CodSpeed Performance Report

Merging #1346 will not alter performance

Comparing fix-double-adding-of-the-same-related (1871aca) with master (ef705cc)

Summary

✅ 84 untouched benchmarks

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fbde811) to head (1871aca).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1346   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       205    +1     
  Lines        14845     14904   +59     
=========================================
+ Hits         14845     14904   +59     
Files Coverage Δ
ormar/relations/relation_proxy.py 100.00% <100.00%> (ø)
tests/test_hashes/test_many_to_many.py 100.00% <100.00%> (ø)

@collerek collerek merged commit e3f95b9 into master Jun 9, 2024
20 checks passed
@collerek collerek deleted the fix-double-adding-of-the-same-related branch June 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the same item twice to a RelationProxy corrupts the _relation_cache
1 participant