Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip compression when response is streamed #31

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Skip compression when response is streamed #31

merged 1 commit into from
Apr 13, 2022

Conversation

gilad9366
Copy link
Contributor

In case a flask response is streamed, we want to skip compression.
See discussion for further details

@alexprengere
Copy link
Collaborator

Is the is_streamed attribute recent? (Does this break compatibility for certain version of Flask?) If that is the case we should reflect this in the docs.

@alexprengere alexprengere merged commit 9a5ef1a into colour-science:master Apr 13, 2022
@gilad9366
Copy link
Contributor Author

No, not recent.
I see it goes back to werkzeug 0.14.x which is the oldest version I found

@alexprengere
Copy link
Collaborator

For the record I made a release containing this fix, until we have (maybe) better support for streaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilad9366 @alexprengere